Changeset 1062

Timestamp:

11/22/09 16:34:35 (2 years ago)

Author:

bogdan2412

Message:

Fix diff between revisions sometimes erroring

The problem was caused by fread not reading the full data from pipes. It apparently reads things in chunks as their are outputed to the pipe and since we close the pipe after a single read, iconv errors and says "broken pipe".
Replaced fread with stream_get_contents as is exemplified in the php manual and everything works ok.

Review URL: ​http://reviewboard.infoarena.ro/r/98/

File:

• trunk/common/diff.php (modified) (1 diff)

trunk/common/diff.php

@@ -107 +107 @@
     fclose($lcs_in);
 
-    $result = fread($lcs_out, 10000);
+    $result = stream_get_contents($lcs_out);
     fclose($lcs_out);
 
     // check for errors
-    $errors = fread($lcs_err, 1000);
+    $errors = stream_get_contents($lcs_err);
     if ($errors) {
         log_error($errors);