Changeset 1076 for trunk

Timestamp:

12/13/09 18:05:25 (2 years ago)

Author:

gcosmin

Message:

Constraints for virtual contests.

Solves ticket #372.
Review URL: ​http://reviewboard.infoarena.ro/r/116/

Location:

trunk

Files:

• common/common.php (modified) (1 diff)
• common/round.php (modified) (3 diffs)
• www/controllers/round.php (modified) (2 diffs)

trunk/common/common.php

@@ -78 +78 @@
 define("IA_TLF_TRIED", '2');
 define("IA_TLF_SOLVED", '3');
+
+// Constants for IA user-defined rounds
+// Users can't create rounds lasting 123141231223 hours
+define("IA_USER_DEFINED_ROUND_DURATION_LIMIT", '48');
+// Users can't create rounds 5412312421 days before the round starts
+define("IA_USER_DEFINED_ROUND_DAYSBEFORE_LIMIT", '30');
+// Users can't create user defined rounds with too many problems
+define("IA_USER_DEFINED_ROUND_TASK_LIMIT", '25');
 
 // Windows hack for checkdnsrr function.

trunk/common/round.php

@@ -51 +51 @@
 function round_validate_parameters($round_type, $parameters) {
     $errors = array();
-    if ($round_type == 'classic' or $round_type == 'user-defined') {
+    if ($round_type == 'classic' or $round_type == 'user-defined'
+            or $round_type == 'archive') {
         // Check duration
         $duration = getattr($parameters, 'duration');
@@ -57 +58 @@
             $errors['duration'] = "Durata trebuie specificata";
         }
+
+        if ($round_type == 'user-defined') {
+            if ($duration > IA_USER_DEFINED_ROUND_DURATION_LIMIT) {
+                $errors['duration'] = "Durata maxim admisa este de " .
+                    IA_USER_DEFINED_ROUND_DURATION_LIMIT . " ore";
+            }
+        }
+
         if (!is_numeric($duration) || $duration < 0) {
             $errors['duration'] = "Durata trebuie sa fie un numar pozitiv";
         }
-    } elseif ($round_type == 'archive') {
-        // Empty...
     } else {
         log_error("Bad round_type");
@@ -119 +126 @@
     if (!is_db_date(getattr($round, 'start_time', db_date_format()))) {
         $errors['start_time'] = "Timpul trebuie specificat ca YYYY-MM-DD HH:MM:SS";
+    } else {
+        if ($round['type'] == 'user-defined') {
+            $current_time = db_date_parse(date("Y-m-d H:i:s"));
+            $round_time = db_date_parse($round['start_time']);
+
+            if (($round_time - $current_time) >
+                    IA_USER_DEFINED_ROUND_DAYSBEFORE_LIMIT * 60 * 60 * 24) {
+                $errors['start_time'] = "Nu poti creea o runda cu mai mult de "
+                    . IA_USER_DEFINED_ROUND_DAYSBEFORE_LIMIT . " zile inainte";
+            }
+        }
     }
 

trunk/www/controllers/round.php

@@ -116 +116 @@
     // Validate task list.
     $new_round_tasks = $values['tasks'];
+
     if (!is_array($new_round_tasks)) {
         $errors['tasks'] = 'Valori invalide.';
@@ -130 +131 @@
         }
     }
+
+    if (request_is_post() && count($values['tasks']) == 0) {
+        $errors['tasks'] = "Trebuie sa alegi cel putin o problema";
+    }
+
+    // Additional validation for user defined tasks
+    if (!array_key_exists('tasks', $errors)
+        && $values['type'] == 'user-defined' &&
+        count($values['tasks']) > IA_USER_DEFINED_ROUND_TASK_LIMIT) {
+            $errors['tasks'] = "Nu poti alege mai mult de " .
+            IA_USER_DEFINED_ROUND_TASK_LIMIT . " probleme";
+        }
+
     if (array_key_exists('tasks', $errors)) {
         $values['tasks'] = array();