Changeset 1079 for trunk

Timestamp:

12/14/09 13:02:28 (2 years ago)

Author:

bogdan2412

Message:

Updated tagging backend again.

Added a column in ia_tags for a tag's parent and got rid of the string prefixes we used before.
Review URL: ​http://reviewboard.infoarena.ro/r/118/

Location:

trunk

Files:

• common/common.php (modified) (1 diff)
• common/db/blog.php (modified) (2 diffs)
• common/db/tags.php (modified) (6 diffs)
• common/tags.php (modified) (1 diff)
• common/textblock.php (modified) (1 diff)
• scripts/migrate-task-tags (modified) (1 diff)
• www/controllers/task.php (modified) (3 diffs)

trunk/common/common.php

@@ -247 +247 @@
         return false;
     }
-    return is_tag_name($tag["name"]) && is_tag_type($tag["type"]);
+    if (!array_key_exists("parent", $tag)) {
+        return false;
+    }
+    return (
+        is_tag_name($tag["name"]) &&
+        is_tag_type($tag["type"]) &&
+        is_tag_id($tag["parent"])
+    );
 }
 

trunk/common/db/blog.php

@@ -5 +5 @@
 function blog_get_range($tag_name, $start, $range) {
     if (is_tag_name($tag_name)) {
-        $tag_id = tag_get_id(array("name" => $tag_name, "type" => "tag"));
+        $tag_id = tag_get_id(array(
+            "name" => $tag_name, "type" => "tag", "parent" => 0));
         if (is_null($tag_id)) {
             $tag_id = -1;
@@ -38 +39 @@
 function blog_count($tag_name) {
     if (is_tag_name($tag_name)) {
-        $tag_id = tag_get_id(array("name" => $tag_name, "type" => "tag"));
+        $tag_id = tag_get_id(array(
+            "name" => $tag_name, "type" => "tag", "parent" => 0));
         if (is_null($tag_id)) {
             $tag_id = -1;

trunk/common/db/tags.php

@@ -4 +4 @@
 require_once(IA_ROOT_DIR."common/common.php");
 
-// Get list of all tag names, filtered by type
-function tag_get_all($types = null) {
-    $query = "SELECT name, type FROM ia_tags";
+// Get list of all tag names, filtered by type and parent
+function tag_get_all($types = null, $parent = null) {
+    $query = "SELECT name, type, parent FROM ia_tags";
+    $where = array();
     if (!is_null($types)) {
         log_assert(is_array($types), "types should be an array");
@@ -13 +14 @@
         }
 
-        $query .= sprintf(" WHERE type IN (%s)",
+        $where[] = sprintf("(type IN (%s))",
             implode(',', array_map('db_quote', $types))
         );
     }
+    if (!is_null($parent)) {
+        log_assert(is_tag_id($parent));
+        $where[] = sprintf("(parent = %s)", db_quote($parent));
+    }
+    if (count($where)) {
+        $query .= sprintf(" WHERE %s", implode(" AND ", $where));
+    }
     return db_fetch_all($query);
 }
 
 // Get list of all tags for a certain object, filtered by type
-function tag_get($obj, $obj_id, $type = null) {
+function tag_get($obj, $obj_id, $type = null, $parent = null) {
     log_assert(is_taggable($obj));
     log_assert(is_null($type) || is_tag_type($type));
@@ -29 +37 @@
         $where_type = sprintf(" AND tags.type = %s", db_quote($type));
     }
+    if (is_null($parent)) {
+        $where_parent = "";
+    } else {
+        $where_parent = sprintf(" AND tags.parent = %s", db_quote($parent));
+    }
     $query = sprintf(
-        "SELECT %s_id, tag_id, tags.name AS tag_name, tags.type AS tag_type
+        "SELECT %s_id, tag_id,
+        tags.name AS tag_name, tags.type AS tag_type, tags.parent AS tag_parent
         FROM ia_%s_tags AS obj_tags
         LEFT JOIN ia_tags AS tags ON obj_tags.tag_id = tags.id
-        WHERE %s_id = %s%s",
+        WHERE %s_id = %s%s%s",
         db_escape($obj), db_escape($obj), db_escape($obj),
-        db_quote($obj_id), $where_type
+        db_quote($obj_id), $where_type, $where_parent
     );
     return db_fetch_all($query);
@@ -44 +58 @@
     log_assert(is_tag($tag));
     $query = sprintf(
-        "SELECT id FROM ia_tags WHERE name = %s AND type = %s",
-        db_quote($tag["name"]), db_quote($tag["type"])
+        "SELECT id FROM ia_tags WHERE name = %s AND type = %s AND parent = %s",
+        db_quote($tag["name"]), db_quote($tag["type"]), db_quote($tag["parent"])
     );
     $result = db_fetch($query);
@@ -56 +70 @@
     foreach ($tags as $tag) {
         log_assert(is_tag($tag));
-        $tag_wheres[] = sprintf("(name = %s AND type = %s)",
-            db_quote($tag["name"]), db_quote($tag["type"]));
+        $tag_wheres[] = sprintf(
+            "(name = %s AND type = %s AND parent = %s)",
+            db_quote($tag["name"]), db_quote($tag["type"]),
+            db_quote($tag["parent"])
+        );
     }
     $query = sprintf("SELECT id FROM ia_tags WHERE %s",
@@ -69 +86 @@
     $id = tag_get_id($tag);
     if (is_null($id)) {
-        $query = sprintf("INSERT INTO ia_tags (name, type) VALUES (%s, %s)",
-            db_quote($tag['name']), db_quote($tag['type']));
+        $query = sprintf(
+            "INSERT INTO ia_tags (name, type, parent) VALUES (%s, %s, %s)",
+            db_quote($tag['name']), db_quote($tag['type']),
+            db_quote($tag['parent'])
+        );
         db_query($query);
         return db_insert_id();

trunk/common/tags.php

@@ -31 +31 @@
 }
 
-function tag_build_list($obj, $obj_id, $type, $remove_prefix = true) {
-    $tag_list = tag_get($obj, $obj_id, $type);
+function tag_build_list($obj, $obj_id, $type, $parent = null) {
+    $tag_list = tag_get($obj, $obj_id, $type, $parent);
     $tag_names = array();
     foreach ($tag_list as $tag) {
-        if ($remove_prefix) {
-            $tag_parts = explode('@', $tag['tag_name']);
-            $tag_names[] = trim($tag_parts[ count($tag_parts) - 1 ]);
-        } else {
-            $tag_names[] = $tag['tag_name'];
-        }
+        $tag_names[] = $tag['tag_name'];
     }
     return implode(", ", $tag_names);
 }
 
-function tag_update($obj, $obj_id, $type, $tag_data, $tag_prefix = "") {
+// Receives a list of tags of a certain type and, optionally, with a
+// certain parent and updates the tag list for the specified object.
+// Returns a list of tag ids.
+function tag_update($obj, $obj_id, $type, $tag_data, $parent = 0) {
     tag_clear($obj, $obj_id, $type);
     $tag_data = tag_split($tag_data);
+    $tag_ids = array();
     foreach ($tag_data as $tag_name) {
-        $tag_id = tag_assign_id(array("name" => $tag_prefix.$tag_name, "type" => $type));
+        $tag_id = tag_assign_id(
+            array("name" => $tag_name, "type" => $type, "parent" => $parent));
+        $tag_ids[] = $tag_id;
         tag_add($obj, $obj_id, $tag_id);
     }
+    return $tag_ids;
 }
 

trunk/common/textblock.php

@@ -49 +49 @@
         // 'stiri'. On the other hand, this operation is cached and we
         // shouldn't worry too much about performance.
-        if ($whole_news && tag_exists('textblock', $tb['name'],
-            tag_get_id(array("name" => 'stiri', "type" => "tag")))) {
+        if ($whole_news && tag_exists('textblock', $tb['name'], tag_get_id(
+            array("name" => 'stiri', "type" => "tag", "parent" => 0)))) {
             // Don't compute snippet for news -- they should be rendered as
             // they are in the snippet.

trunk/scripts/migrate-task-tags

@@ -8 +8 @@
     ALTER TABLE `ia_tags`
     ADD COLUMN `type` ENUM('author','contest','year','round','age_group','method','algorithm','tag') NOT NULL,
+    ADD COLUMN `parent` INTEGER NOT NULL DEFAULT 0,
     DROP INDEX `name`,
-    ADD UNIQUE INDEX `name_type` USING BTREE(`name`, `type`)
+    ADD UNIQUE INDEX `name_type` USING BTREE(`name`, `type`, `parent`)
 ");
 db_query('UPDATE `ia_tags` SET `type` = "tag"');

trunk/www/controllers/task.php

@@ -70 +70 @@
     // FIXME: tags that have children such as contest, year or round should have only one tag
     foreach ($tag_types as $type) {
-        $remove_prefix = isset($tag_parents[$type]);
-        $values['tag_'.$type] = request('tag_'.$type, tag_build_list('task', $task_id, $type, $remove_prefix));
-        $prefix['tag_'.$type] = '';
-        if (isset($tag_parents[$type])) {
-            $parent_type = $tag_parents[$type];
-            $prefix['tag_'.$type] = $prefix['tag_'.$parent_type].$values['tag_'.$parent_type]."@";
-        }
+        $values['tag_'.$type] = request('tag_'.$type,
+            tag_build_list('task', $task_id, $type));
     }
 
@@ -144 +139 @@
 
         // If no errors then do the db monkey
+        $tags = array();
         if (!$errors) {
             // FIXME: error handling? Is that even remotely possible in php?
@@ -151 +147 @@
             if (identity_can('task-tag', $new_task)) {
                 foreach ($tag_types as $type) {
-                    tag_update('task', $new_task['id'], $type, $values['tag_'.$type], $prefix['tag_'.$type]);
+                    $parent = 0;
+                    if (isset($tag_parents[$type])) {
+                        $parent = $tags[$tag_parents[$type]][0];
+                    }
+                    $tags[$type] = tag_update('task', $new_task['id'], $type,
+                        $values['tag_'.$type], $parent);
                 }
             }