Changeset 1106 for trunk

Timestamp:

03/14/10 18:30:11 (2 years ago)

Author:

gcosmin

Message:

You can now deselect all tags for a task
review url: ​http://reviewboard.infoarena.ro/r/133/

Location:

trunk

Files:

• common/db/tags.php (modified) (2 diffs)
• common/tags.php (modified) (1 diff)
• www/controllers/task.php (modified) (3 diffs)

trunk/common/db/tags.php

@@ -61 +61 @@
 // Each parent id appears only once
 function tag_get_parents($tag_ids) {
+    if (count($tag_ids) == 0) {
+        return array();
+    }
+
     $query = sprintf("SELECT DISTINCT(`parent`)
             FROM ia_tags
@@ -103 +107 @@
 // Get a list of tags from a list of tag ids
 function tag_get_by_ids($tag_ids) {
+    if (count($tag_ids) == 0) {
+        return array();
+    }
+
     $query = sprintf(
             "SELECT `id`, `name`, `type`, `parent`

trunk/common/tags.php

@@ -83 +83 @@
     foreach ($tags_by_id as &$tag) {
         if (!isset($has_parent[$tag["id"]])) {
+            // Set the array for the tags with no parents and no children
+            if (!isset($tag["sub_tags"])) {
+                $tag["sub_tags"] = array();
+            }
             $roots[] = $tag;
         }

trunk/www/controllers/task.php

@@ -284 +284 @@
 
     if (request_is_post()) {
-        $algorithm_tags_id = request("algorithm_tags");
+        $algorithm_tags_id = request("algorithm_tags", array());
         $method_tags_id = tag_get_parents($algorithm_tags_id);
 
         if (!is_array($algorithm_tags_id)) {
             flash_error("Datele trimise sunt invalide. Raporteaza aceasta problema unui admin.");
-            redirect(url_task_edit_tag($task_id));
+            redirect(url_task_edit_tags($task_id));
         }
 
@@ -295 +295 @@
             if (!is_tag_id($tag_id)) {
                 flash_error("Datele trimise sunt invalide. Raporteaza aceasta problema unui admin.");
-                redirect(url_task_edit_tag($task_id));
+                redirect(url_task_edit_tags($task_id));
             }
         }
@@ -308 +308 @@
         if ($count != count($algorithm_tags_id)) {
             flash_error("Datele trimise sunt invalide. Raporteaza aceasta problema unui admin.");
-            redirect(url_task_edit_tag($task_id));
+            redirect(url_task_edit_tags($task_id));
         }