Changeset 1137 for trunk/common

Timestamp:

04/25/10 17:47:20 (2 years ago)

Author:

bogdan2412

Message:

Fix round_recompute_score function.

It now correctly handles the case where some user's score is present
in ia_score_user_round_task but not in ia_score_user_round. Also
does less DB queries now.

File:

• trunk/common/db/round.php (modified) (1 diff)

trunk/common/db/round.php

@@ -57 +57 @@
 
 function round_recompute_score($round_id) {
-    $query = "SELECT * FROM `ia_score_user_round`
-        WHERE `round_id` = ".db_quote($round_id);
+    db_query("DELETE FROM ia_score_user_round
+        WHERE round_id = ".db_quote($round_id));
+    $query = "SELECT SUM(`score`) AS score, user_id
+        FROM ia_score_user_round_task
+        WHERE `round_id` = ".db_quote($round_id)."
+        GROUP BY `user_id`";
     $rows = db_fetch_all($query);
-    $users = array();
-    foreach ($rows as $row) {
-      $users[] = $row['user_id'];
-    }
-
-    $query = "SELECT SUM(`score`) AS score, user_id
-            FROM ia_score_user_round_task
-            WHERE `user_id` IN ('".implode("', '", $users)."') AND
-                  `round_id` = ".db_quote($round_id)."
-            GROUP BY `user_id`";
-    $rows = db_fetch_all($query);
+    if (empty($rows)) {
+        return false;
+    }
+    $query = "INSERT INTO `ia_score_user_round`
+        (`user_id`, `round_id`, `score`)
+        VALUES ";
+    $first = true;
     foreach($rows as $row) {
         $user_id = $row['user_id'];
         $score = $row['score'];
 
-        $query = "UPDATE `ia_score_user_round`
-                    SET `score` = ".db_quote($score)."
-                    WHERE `user_id` = ".db_quote($user_id)." &&
-                          `round_id` = ".db_quote($round_id);
-        db_query($query);
-    }
+        if (!$first) {
+            $query .= ", ";
+        } else {
+            $first = false;
+        }
+        $query .= sprintf("(%s, %s, %s)",
+            db_quote($user_id), db_quote($round_id), db_quote($score));
+    }
+    db_query($query);
 }