Changeset 1155 for trunk/common

Timestamp:

11/12/11 17:18:55 (6 months ago)

Author:

adrian.budau

Message:

Avatar Optimization

This is an optimization for managing avatars on the server. Because
there are only 5 sizes used on all the site it's more useful to resize
all of the images to those 5(thus increasing the space usage by less
than 100%) and when a client asks for a size give it directly rather
then resizing all the time. The 5 sizes are tiny (old L16x16),
small(old L32x32), normal(old L50x50), forum(old L75xL75, used only on

the forum at the moment), big(old 100x100) and full(the original picture).

To get the avatar on a size from the server simply use the page
avatar/%some_size%/%some_user where %some_user% is a username and
%some_size$ is a one the 5 sizes. In case the user doesn't exists or he
doesn't have an avatar we use a placeholder image. If the size given is
not from the list or is omitted the server return a classic
404 Error(File not found)

The script which resizes the image for the current users is called
make-avatar-folder found in the scripts folder. It requires the attach
folder to have permission for read and write.

The setup has also been modified so fresh installes will work without
calling the script.

Reviewboard Link: ​http://reviewboard.infoarena.ro/r/176/

Location:

trunk/common

Files:

• attachment.php (modified) (1 diff)
• avatar.php (added)
• common.php (modified) (1 diff)
• db/user.php (modified) (1 diff)

trunk/common/attachment.php

@@ -146 +146 @@
 }
 
+/**
+ * Resizes an image whose filepath is given by the parameters into a new
+ * location specified by the other parameters
+ *
+ * Returns whether or not the image has been successfully resized
+ * Note that it returns false if the image doesn't have a known file-type
+ *
+ * The $new_filepath parameter if ommited or given as null will result in the
+ * image being outputted directly to the client
+ *
+ * @param  array   $image_info         An array containing information about the
+ *                                     original image: width, height, mime-type
+ * @param  string  $filepath
+ * @param  array   $new_image_info     An array containing the new width and
+ *                                     height
+ * @param  string  $new_filepath
+ * @return bool
+ */
+function image_resize($image_info, $filepath, $new_image_info,
+        $new_filepath = null) {
+    list($image_width, $image_height, $image_type, $image_attribute) = $image_info;
+    list($new_image_width, $new_image_height) = $new_image_info;
+
+    switch ($image_type) {
+        case IMAGETYPE_GIF:
+            // NOTE: animated GIFs become static. Only the first frame is saved
+            // Seems like a good thing anyway
+            $image = imagecreatefromgif($filepath);
+            $image_resized = imagecreate($new_image_width, $new_image_height);
+            // reset palette and transparent color to that of the original file
+            $trans_col = imagecolortransparent($image);
+            imagepalettecopy($image_resized, $image);
+            imagefill($image_resized, 0, 0, $trans_col);
+            imagecolortransparent($image_resized, $trans_col);
+            imagecopyresampled($image_resized, $image, 0, 0, 0, 0,
+                    $new_image_width, $new_image_height, $image_width,
+                    $image_height);
+
+            if ($new_filepath != null) {
+                return imagegif($image_resized, $new_filepath);
+            }
+            return imagegif($image_resized);
+
+        case IMAGETYPE_JPEG:
+            $image = imagecreatefromjpeg($filepath);
+            $image_resized = imagecreatetruecolor($new_image_width,
+                    $new_image_height);
+            imagecopyresampled($image_resized, $image, 0, 0, 0, 0,
+                    $new_image_width, $new_image_height, $image_width,
+                    $image_height);
+
+            if ($new_filepath != null) {
+                return imagejpeg($image_resized, $new_filepath);
+            }
+            return imagejpeg($image_resized);
+
+        case IMAGETYPE_PNG:
+            $image = imagecreatefrompng($filepath);
+            $image_resized = imagecreatetruecolor($new_image_width,
+                    $new_image_height);
+            // turn off the alpha blending to keep the alpha channel
+            imagealphablending($image_resized, false);
+            // allocate transparent color
+            $col = imagecolorallocatealpha($image_resized, 0, 0, 0, 127);
+            // fill the image with the new color
+            imagefilledrectangle($image_resized, 0, 0, $new_image_width,
+                    $new_image_height, $col);
+            imagecopyresampled($image_resized, $image, 0, 0, 0, 0,
+                    $new_image_width, $new_image_height, $image_width,
+                    $image_height);
+            imagesavealpha($image_resized, true);
+            if ($new_filepath != null) {
+                return imagepng($image_resized, $new_filepath);
+            }
+            return imagepng($image_resized);
+
+        default:
+            // unsupported image type
+            return false;
+    }
+}
 ?>

trunk/common/common.php

@@ -260 +260 @@
 function is_taggable($obj) {
     return $obj == 'user' || $obj == 'task' || $obj == 'round' || $obj == 'textblock';
+}
+
+/**
+ * Returns whether or not the size type given is an existent one on the site
+ *
+ * @param  string  $size_type
+ * @return bool
+ */
+function is_valid_size_type($size_type) {
+    $size_types = array("full", "tiny", "small", "normal", "forum", "big");
+    return in_array($size_type, $size_types);
 }
 

trunk/common/db/user.php

@@ -168 +168 @@
 {
     log_assert_valid(user_validate($user));
-    
+
     // Update DB
     db_update("ia_user", $user, "id = ".db_quote($user['id']));