Changeset 1161

Timestamp:

12/10/11 15:50:01 (5 months ago)

Author:

savin.tiberiu@…

Message:

Bugfixes:

Fixed a bug for intern permissions

• Fixed the reeval bug

review link: ​http://reviewboard.infoarena.ro/r/179/

Location:

trunk

Files:

• common/security.php (modified) (1 diff)
• www/controllers/reeval.php (modified) (1 diff)

trunk/common/security.php

@@ -578 +578 @@
     $is_intern = $usersec == 'intern';
     $is_owner = ($job['user_id'] == $user['id']);
-    $is_task_owner = ($job['task_owner_id'] == $user['id'] && $usersec == 'helper');
+    $is_task_owner = ($job['task_owner_id'] == $user['id'] && 
+                      in_array($usersec, array('helper', 'intern')));
     $can_view_job = ($job['task_hidden'] == false) || $is_task_owner || $is_admin;
     $can_view_source = ($job['task_open_source'] == true) || $is_task_owner || 

trunk/www/controllers/reeval.php

@@ -7 +7 @@
     $filters = job_get_filters();
 
-    if (!$filters["task"] ||
+    if (!isset($filters["task"]) ||
             !identity_can('task-reeval', task_get($filters['task']))) {
         identity_require('job-reeval');