Changeset 1164 for trunk/www/macros/macro_toprated.php

Timestamp:

01/14/12 16:18:10 (4 months ago)

Author:

bogdan2412

Message:

Make infoarena compatible with HPHP.

• Implemented APC caching support since eaccelerator is not compatible with HPHP and although we support memcached, we do not use it on live.
• Replaced instances of create_function_cached with php anonymous functions. This bumps the PHP version requirement to 5.3, but it allows the code to work with HPHP, since dynamic function generation is replaced with staticly analyzable functions. This also removes a horrible, terrible hack in Textile.php which was storing the current instance of the Textile class being processed as a static variable so that it could be accessed by anonymous functions.
• Replaced occurrences of assert with log_assert.
• When running under HPHP, IA_HPHP_ENV is defined and is used to bypass some incompatible code (redundant ini configuration checks).
• Fixed some includes that were dependent on the working directory being www/
• Included a sample HPHP configuration file and a Makefile with compilation commands.

REVIEW URL: ​http://reviewboard.infoarena.ro/r/182/

File:

• trunk/www/macros/macro_toprated.php (modified) (1 diff)

trunk/www/macros/macro_toprated.php

@@ -32 +32 @@
             'title' => 'Nume',
             'key' => 'full_name',
-            'rowform' => create_function_cached('$row',
-                                         'return format_user_normal($row["username"], $row["full_name"], $row["rating_cache"]);'),
+            'rowform' => function($row) {
+                return format_user_normal($row['username'], $row['full_name'], $row['rating_cache']);
+            },
         ),
         array(
             'title' => 'Rating',
             'key' => 'rating_cache',
-            'rowform' => create_function_cached('$row', 'return rating_scale($row[\'rating_cache\']);'),
+            'rowform' => function($row) {
+                return rating_scale($row['rating_cache']);
+            },
             'css_class' => 'number rating',
         ),